Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QEMU Guest Agent and Fix Issue with IPAM #120

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

AnushK-Fro
Copy link
Contributor

@AnushK-Fro AnushK-Fro commented Nov 10, 2024

Guest Agent

Changes

  1. Added support for using the QEMU Guest Agent to set passwords on Windows Server installations.
  2. Enabled instant password resets through the Guest Agent, which avoids the need for reboots. Unlike Cloudinit (which requires a reboot to set passwords on Linux), the Guest Agent can update passwords immediately. This also solves the issue of Cloudinit not supporting Windows Server on Proxmox.

Issues

  • The server will be turned on regardless of whether the user checks or unchecks the start on completion function. Having a checkbox to start on completion is probably not required.

IPAM

This change increases the pagination limit for IP addresses. The IPAM is typically slow when trying to assign an IP address to a VM on a node that has more than 100 available IP addresses, since the current approach only provides 100 results each time a user enters a value. There is no need to paginate the IPAM since the amount of data is small. Loading all of the IP addresses at once dramatically speeds up the process of selecting an IP address and makes it less frustrating for the user.

@AnushK-Fro AnushK-Fro changed the title Add support for QEMU Guest Agent Add support for QEMU Guest Agent and Fix Issue with IPAM Nov 10, 2024
@ericwang401
Copy link
Collaborator

The tests need to pass btw

@AnushK-Fro
Copy link
Contributor Author

Should be fixed now

@AnushK-Fro AnushK-Fro mentioned this pull request Nov 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants